[PATCH] D145131: [Arm][AArch64] Setting IsX18ReservedByDefault() to true for Unknown OSes
Benoit Jacob via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 2 07:19:40 PST 2023
Benoit added a comment.
Thank you for the explanation regarding the current constraint that "unknown" includes in particular "bare metal". Do you think that it would make sense going forward to start distinguishing between "bare metal" and "unknown"? After all, knowing that the target is "bare metal" is information in its own right, and here it enables using x18.
Likewise, if there is no `-fno-fixed-x18` flag and that is part of why the present diff is not immediately acceptable, maybe that could be motivation to add a `-fno-fixed-x18` flag.
Just to say, I understand the immediate decision here but I also hope that can be resolved differently in the future.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145131/new/
https://reviews.llvm.org/D145131
More information about the llvm-commits
mailing list