[PATCH] D144756: [SimplifyCFG] Do not hoist/sink convergent function calls

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added inline comments.


================
Comment at: llvm/test/Transforms/SimplifyCFG/convergent.ll:55
+; NOSINK-NEXT:    br i1 [[CMP_NOT]], label [[IF_ELSE:%.*]], label [[IF_THEN:%.*]]
+; NOSINK:       if.then:
+; NOSINK-NEXT:    [[TMP1:%.*]] = tail call i32 @mbcnt(i32 -1, i32 0)
----------------
yaxunl wrote:
> tra wrote:
> > Nit: Do we intend to pattern-match `if.then` here and use `[[IF_THEN]]:` instead?
> > 
> > I guess we should either consistently use captured labels, or literal label names everywhere.
> that is done by utils/update_test_checks.py. need a separate patch to fix utils/update_test_checks.py.
I have a patch for that at https://reviews.llvm.org/D142452, I just haven't been able to follow up over the last month.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144756/new/

https://reviews.llvm.org/D144756