[PATCH] D131587: [CodeGen] Deduplicate restore blocks in branch relaxation

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 2 03:21:03 PST 2023


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:2558
 
-  // FIXME: If spilling is necessary, this will fail because this scavenger has
-  // no emergency stack slots. It is non-trivial to spill in this situation,
----------------
piggynl wrote:
> foad wrote:
> > Why is this removed?
> Because D106449 has already addressed this case.
Then please commit it separately.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131587/new/

https://reviews.llvm.org/D131587



More information about the llvm-commits mailing list