[PATCH] D144445: [ConstantFold][InstSimplify] folding load for constant global patterened arrays and structs

Thu Mar 2 02:38:18 PST 2023

khei4 planned changes to this revision.
khei4 added a comment.

In D144445#4155524 <https://reviews.llvm.org/D144445#4155524>, @nikic wrote:

>> it might be better to move this to aggressive inst-combine or refactor
>
> Based on those numbers, it does seem pretty likely that we'll have to move this into AggressiveInstCombine. That would also give a bit more leeway wrt globals sizes. And I don't think it would really reduce optimization potential in any meaningful way -- this doesn't seem like the kind of fold that benefits from being run 20 times in the optimization pipeline.

https://llvm-compile-time-tracker.com/compare.php?from=6f3baf43820680841b0daebdde2c78b43175444b&to=c08adfbed285199cd839da40419f918ac7a863b1&stat=instructions:u

@nikic 
Thanks to your feedback, regression relaxed, but yet seems so much to move this to AggressiveInstCombine. I'll move.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144445/new/

https://reviews.llvm.org/D144445