[PATCH] D144783: [ELF] Move getSectionAndRelocations to ELF.cpp from ELFDumper.cpp
Rahman Lavaee via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Mar 2 01:11:02 PST 2023
rahmanl added inline comments.
================
Comment at: llvm/include/llvm/Object/ELF.h:397
+ Error getSectionAndRelocations(
+ std::function<Expected<bool>(const Elf_Shdr &)> IsMatch,
+ llvm::MapVector<const Elf_Shdr *, const Elf_Shdr *> &SecToRelocMap) const;
----------------
Let's not add complexity here. IsMatch should be a simple function which returns true or false.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144783/new/
https://reviews.llvm.org/D144783
More information about the llvm-commits
mailing list