[PATCH] D145108: [RISCV][llvm-tblgen] Support conditional definitions using !exists clauses

Wang Pengcheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 1 22:43:35 PST 2023


pcwang-thead accepted this revision.
pcwang-thead added a comment.
This revision is now accepted and ready to land.

Thanks for improving this and it's really a helpful extension I think.
The code is LGTM and the detailed description is explanatory, but please wait a few days for others' opinions.



================
Comment at: llvm/lib/TableGen/TGParser.cpp:387
                        SMLoc *Loc) {
+
   MapResolver R;
----------------
Remove this blank please.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145108/new/

https://reviews.llvm.org/D145108



More information about the llvm-commits mailing list