[PATCH] D144308: [llvm-cov] Optionally fail on missing binary ID

[Gulfem Savrun Yeniceri via Phabricator via llvm-commits]

gulfem accepted this revision.
gulfem added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/ProfileData/Coverage/CoverageMapping.cpp:435
+      if (!PathOpt) {
+        if (CheckBinaryIDs) {
+          return createFileError(
----------------
Just a cosmetic suggestion: I am not a big fan of reading a 4-level nested structure.
I was thinking that you can just use `if (PathOpt)` instead and swap then and else parts. You can also get rid of `continue`.
This is just a nit-pick, and feel free to land it without that if you prefer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144308/new/

https://reviews.llvm.org/D144308