[PATCH] D144927: [GVNHoist] don't hoist callbr users into the callbr's block

Wed Mar 1 17:06:22 PST 2023

nickdesaulniers added a comment.

In D144927#4163320 <https://reviews.llvm.org/D144927#4163320>, @nickdesaulniers wrote:

> In D144927#4163308 <https://reviews.llvm.org/D144927#4163308>, @nickdesaulniers wrote:
>
>> Shouldn't `callbr` have it's own dedicated `MemoryDef` that's distinct from `liveOnEntry`?
>
> Hmm..maybe not? We don't for vanilla inline asm (non-asm-goto) that modifies memory: https://godbolt.org/z/4144Wd7e1. Shouldn't inline asm qualify as a `MemoryAccess` when `"m"` constraints are used?

NVM, we do: https://godbolt.org/z/9EhW14z9W ...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144927/new/

https://reviews.llvm.org/D144927