[PATCH] D145008: [ControlHeightReduction] Don't combine a "poison" branch

Wed Mar 1 15:59:18 PST 2023

kazu added a comment.

In D145008#4163051 <https://reviews.llvm.org/D145008#4163051>, @nikic wrote:

> A branch on poison should really not reach this code and get optimized away to unreachable earlier -- the reason it isn't is that this would take some annoying test updates, see D140892 <https://reviews.llvm.org/D140892>.

I was actually getting `br i1 poison` prior to b374423304a8d91d590d0ce5ab1b381296d6dfb2 <https://reviews.llvm.org/rGb374423304a8d91d590d0ce5ab1b381296d6dfb2>, which moved the CHR pass to module optimization pipeline.

I just updated the patch here.  Please take a look.  Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145008/new/

https://reviews.llvm.org/D145008