[PATCH] D143673: [lld][RISCV] Implement GP relaxation for R_RISCV_HI20/R_RISCV_LO12_I/R_RISCV_LO12_S.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 1 14:06:04 PST 2023


MaskRay added inline comments.


================
Comment at: lld/ELF/Writer.cpp:842
+  RF_BSS = 1 << 9,
+  RF_RISCV_NOT_SBSS = 1 << 8,
+  RF_RISCV_SDATA = 1 << 7,
----------------
MaskRay wrote:
> Make `RF_RISCV_NOT_SBSS = RF_PPC_NOT_TOCBSS` so that we don't need to shift the values for `RF_*` above. RISCV and PPC are mutual exclusive.
Ignore this comment. I think D145118 renders this part unneeded.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143673/new/

https://reviews.llvm.org/D143673



More information about the llvm-commits mailing list