[PATCH] D144494: [SPIR-V] Support TargetExtType for SPIR-V builtin types

[Michal Paszkowski via Phabricator via llvm-commits]

mpaszkowski added inline comments.


================
Comment at: llvm/lib/IR/Type.cpp:865
   StringRef Name = Ty->getName();
-  if (Name.startswith("spirv.")) {
+  if (Name.startswith("spirv.") || Name.startswith("opencl.")) {
     return TargetTypeInfo(Type::getInt8PtrTy(C, 0), TargetExtType::HasZeroInit,
----------------
jcranmer-intel wrote:
> Why do you need to support both spirv.* and opencl.* opaque types?
@jcranmer-intel Hi Joshua, Thanks for catching this! I think I forgot to remove it after experimenting with translating OpenCL types to SPIR-V types in the previous version of the patch. We don't need this anymore. I will remove this and fix the typos in a new commit when I get back home.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144494/new/

https://reviews.llvm.org/D144494