[PATCH] D145041: [RISCV] Add classes to define SchedWrite list

[Michael Maitland via Phabricator via llvm-commits]

michaelmaitland added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVScheduleV.td:47
 
+// Define classes to define list contained all SchedWrites for each (name, LMUL)
+// pair for each LMUL in each of the SchedMxList variants above and name in
----------------
`contained` -> `containing`


================
Comment at: llvm/lib/Target/RISCV/RISCVScheduleV.td:49
+// pair for each LMUL in each of the SchedMxList variants above and name in
+// argument `names`. These classes can be used to simplify definitions of writes
+// needed in ReadAdvance. For example:
----------------
I'm not sure that this class simplifies definitions of writes since this class does not define any `SchedWrite`s. Perhaps a better description would be something like `This class can be used to construct a list of existing definitions of writes corresponding to each (name, LMUL) pair, that are needed by the ReadAdvance.`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145041/new/

https://reviews.llvm.org/D145041