[PATCH] D145051: [ADCE] Only remove debug intrinsics if non debug instructions are removed

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

(I happened to have touched this area, you'll need to rebase)



================
Comment at: llvm/lib/Transforms/Scalar/ADCE.cpp:563
+    // delete.
+    if (!isa<DbgInfoIntrinsic>(&I))
+      FoundNonDebugInstr = true;
----------------
can move this into an `else` of the previous if statement


================
Comment at: llvm/test/Transforms/ADCE/debug-info-intrinsic-2.ll:1
+; RUN: opt -passes=adce -S < %s | FileCheck %s
+
----------------
can you use update_test_checks.py?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145051/new/

https://reviews.llvm.org/D145051