[PATCH] D145065: [DAG] expandIntMINMAX - attempt to match existing SETCC node

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 1 08:42:54 PST 2023


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:9568
+
+  llvm_unreachable("How did we get here?");
 }
----------------
Make the fail string more informative:
  llvm_unreachable("Expected max/min opcode");
...could also make that the `default` case of the switch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145065/new/

https://reviews.llvm.org/D145065



More information about the llvm-commits mailing list