[PATCH] D142109: [LoopVectorize] Remove runtime check and scalar tail loop when tail-folding.
Sander de Smalen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 1 07:25:02 PST 2023
sdesmalen added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8753
+ if (Style == TailFoldingStyle::DataAndControlFlow ||
+ Style == TailFoldingStyle::DataAndControlFlowWithoutRuntimeCheck) {
// Create the active lane mask instruction in the vplan preheader.
----------------
sdesmalen wrote:
> fhahn wrote:
> > The code for handling ActiveLaneMask now as grown quite a bit. Do you think it would be possible to separate the logic in different functions? Not in this patch ,but as general cleanup?
> Fair question, I'll try to create a follow-up patch to clean this up a bit!
I have created D145068 for this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142109/new/
https://reviews.llvm.org/D142109
More information about the llvm-commits
mailing list