[PATCH] D144941: [m68k] Add TLS Support

Sheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 1 07:15:28 PST 2023


0x59616e marked an inline comment as done.
0x59616e added inline comments.


================
Comment at: llvm/lib/Target/M68k/M68kISelLowering.cpp:1399
+                             unsigned TargetFlags) {
+  // In general dynamic and local dynamic access models, to access a variable in
+  // Thread Local Storage (TLS), we typically use the function __tls_get_addr.
----------------
0x59616e wrote:
> jrtc27 wrote:
> > None of this is m68k-specific (with the exception of using unsigned instead of unsigned long), these long comments are just a repeat of how ELF TLS works in general. I don't think they belong here.
> The code generation snippet for TLS is complicated. These comments help clarify the details and may be helpful for me or others who come to maintain it in the future.
*The details of how TLS works are complex*


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144941/new/

https://reviews.llvm.org/D144941



More information about the llvm-commits mailing list