[PATCH] D143195: ValueTracking: Add start of computeKnownFPClass API

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/include/llvm/ADT/FloatingPointMode.h:255
 
+inline FPClassTest fneg(FPClassTest Mask) {
+  FPClassTest NewMask = Mask & fcNan;
----------------
Commit these NFC changes separately? It would be nice if they weren't part of the header though.


================
Comment at: llvm/lib/Support/APFloat.cpp:5375
+  return isSignaling() ? fcSNan : fcQNan;
+}
+
----------------
Commit this separately (with more extensive unit test coverage)?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143195/new/

https://reviews.llvm.org/D143195