[PATCH] D144961: [NVPTX] Add f16 and v2f16 ldg builtins

[Jakub Chlanda via Phabricator via llvm-commits]

jchlanda added inline comments.


================
Comment at: llvm/test/CodeGen/NVPTX/ldu-ldg.ll:5-6
 
 declare i8 @llvm.nvvm.ldu.global.i.i8.p1(ptr addrspace(1) %ptr, i32 %align)
 declare i32 @llvm.nvvm.ldu.global.i.i32.p1(ptr addrspace(1) %ptr, i32 %align)
+
----------------
tra wrote:
> Do we want to add missing `ldu` variants, too?
Looks like none of the `ldu` builtins have been exposed yet. I'll do it in a follow up patch.


================
Comment at: llvm/test/CodeGen/NVPTX/ldu-ldg.ll:39
 ; CHECK: func3
-define i32 @func3(ptr addrspace(1) %ptr) {
+define i16 @func3(ptr addrspace(1) %ptr) {
+; ld.global.nc.u16
----------------
tra wrote:
> Nit: I'd give test functions more descriptive names. E.g. `test_ldg_u16`.
Sure, done now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144961/new/

https://reviews.llvm.org/D144961