[PATCH] D142191: [lld][RISCV] Merge subtarget features to get right attributes section

Elena Lepilkina via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 28 23:24:16 PST 2023


eklepilkina added a comment.

> It is not correct to assume that the mere presence of a function with extra attributes changes the requirement of the module.

So could you please clarify what should be used to provide target extensions to linker in case of bitcode files? I saw a comment that using function attributes is the preferable way and I provided the link to code that they are used in `const RISCVSubtarget *
RISCVTargetMachine::getSubtargetImpl`

I'm ready to make fix, butI want to understand what is the right way. May be use some other attribute connected with module or something like this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142191/new/

https://reviews.llvm.org/D142191



More information about the llvm-commits mailing list