[PATCH] D144276: [ORC] Introduce SetUpExecutorNativePlatform utility.

Aman LaChapelle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 28 18:17:19 PST 2023


bzcheeseman added inline comments.


================
Comment at: llvm/include/llvm/ExecutionEngine/Orc/COFFPlatform.h:45
+         JITDylib &PlatformJD,
+         std::unique_ptr<MemoryBuffer> OrcRuntimeArchiveBuffer,
+         LoadDynamicLibrary LoadDynLibrary, bool StaticVCRuntime = false,
----------------
The other platforms use a DefinitionGenerator, any particular reason to not do that here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144276/new/

https://reviews.llvm.org/D144276



More information about the llvm-commits mailing list