[PATCH] D144770: [SLP] Outline GEP chain cost modeling into new TTI interface - NFCI.

[Valeriy Dmitriev via Phabricator via llvm-commits]

vdmitrie added a comment.

> I thought they don't have remarks. Maybe add remarks to some other tests?

Please let me know if you have some specific tests in mind to beef up with pass remark checks.
May be tests with specific patterns? Finding them by looking through every test manually is a bit tedious work.



================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:7183
+        // rather than just single use.
+        if (Ptr && !Ptr->hasOneUse())
+          MultipleUseGEPs.push_back(V);
----------------
vdmitrie wrote:
> ABataev wrote:
> > Use areAllUsersVectorized?
> Yep. That what I was considering. Just though about addressing it in a follow up patch. 
I experimented with replacing single use check with areAllUsersVectorized(). Yes, that's what we want but it makes the patch non-NFC. So I'd like to make that change separately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144770/new/

https://reviews.llvm.org/D144770