[PATCH] D143390: [BOLT] Add writable segment for allocatable sections

Rafael Auler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 28 14:43:24 PST 2023


rafauler added inline comments.


================
Comment at: bolt/lib/Rewrite/RewriteInstance.cpp:4044
+
+  // NOTE Currently .eh_frame_hdr appends to the last segment, recalculate
+  // last segments size based on the NextAvailableAddress variable.
----------------
Is .eh_frame_hdr part of this new writable segment? Shouldn't it go to the read-only segment? Why is eh_frame_hdr being mapped to the last segment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143390/new/

https://reviews.llvm.org/D143390



More information about the llvm-commits mailing list