[PATCH] D144449: [X86] Improve select of constants

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/test/CodeGen/X86/select-constant-xor.ll:61
+; X64-NEXT:    sets %al
+; X64-NEXT:    addl $2147483647, %eax # imm = 0x7FFFFFFF
 ; X64-NEXT:    retq
----------------
goldstein.w.n wrote:
> RKSimon wrote:
> > goldstein.w.n wrote:
> > > Not that it needs to be fixed now, but shouldn't this be:
> > > ```
> > > shr $63, %rdi
> > > lea  2147483647(%rdi),%eax
> > > ```
> > > ?
> > @goldstein.w.n Please can you raise a ticket?
> Working on a patch for it, will have one up soon.
@RKSimon see: D145002


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144449/new/

https://reviews.llvm.org/D144449