[PATCH] D143748: [BOLT] Improve dynamic relocations support for CI

[Vladislav Khmelevsky via Phabricator via llvm-commits]

yota9 added inline comments.


================
Comment at: bolt/lib/Core/BinaryContext.cpp:394
     if (IslandIter != AddressToConstantIslandMap.end()) {
-      if (MCSymbol *IslandSym =
-              IslandIter->second->getOrCreateProxyIslandAccess(Address, BF)) {
+      // We would refer original CI if it has dynamic relocations in it
+      if (IslandIter->second->hasDynamicRelocationAtIsland()) {
----------------
rafauler wrote:
> Is this because we don't support cloning dynamic relocs? If yes, we can expand this comment to clarify:
> 
> // Fall-back to referencing the original constant island in the presence of dynamic relocs, as we currently do not support cloning them. Notice: we might fail to link because of this, if the original constant island is far away.
> 
> 
Yes, it is true. Add comment


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143748/new/

https://reviews.llvm.org/D143748