[PATCH] D142282: [Support] Implement findModulesAndOffsets on Apple 64-bit platforms

Tue Feb 28 10:53:51 PST 2023

mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.

LG to me!

In D142282#4142831 <https://reviews.llvm.org/D142282#4142831>, @dblaikie wrote:

> I have some reservations about this, given the reservations about https://reviews.llvm.org/D142283 - but I guess this part of the work's relatively neutral, even if a more robust implementation of debug-info finding for MachO is implemented rather than the dsym hints direction.

This patch is just the part about finding the offset, it is orthogonal to D142283 <https://reviews.llvm.org/D142283> in that with just the patch we have here we will correctly symbolize traces if we run separately `dsymutil` on the binary.

Having llvm-symbolizer be able to do the work of `dsymutil` automatically would be nice as well of course :)

> Though some of the discussion there sounds like the more robust direction might be too much work/invasive/not very standalone, and maybe folks would be better off using the apple tool atos insetad?

Any direction would be based on top of this patch anyway I think?

================
Comment at: llvm/lib/Support/Unix/Signals.inc:546
+    }
+  }
+  return true;
----------------
The variable style isn't LLVM right now it seems, can you fix it?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142282/new/

https://reviews.llvm.org/D142282