[PATCH] D144963: [UTC] Include return type/attributes under --version 2

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.

In D144963#4158771 <https://reviews.llvm.org/D144963#4158771>, @nikic wrote:

> In D144963#4158739 <https://reviews.llvm.org/D144963#4158739>, @asb wrote:
>
>> This LGTM in general. I have just one question about how you imagine changing the incorporation of D140212 <https://reviews.llvm.org/D140212> - would you add in the `--function-signature` by default change to `--version 2`, or introduce a `--version 3`? I think I'd be happy enough with either, but wanted to check your plan.
>
> My plan was to both enable `--function-signature` by default and check return types as part of `--version 2`. But I would be fine keeping them separate as well (in which case I'd bump the default version in this patch).

I thought I'd flag it in case others felt strongly otherwise, but doing it as part of `--version 2` seems fine to me. It might seem a bit weird if you see `--version` as an attempt to give an immutable output format for UTC at a point in time. But if you see it as just a tool to help reduce in-tree test churn when adding new features, then logically we have the option of extending the current "version" as an alternative to defining a new one, if it's not too disruptive to do so.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144963/new/

https://reviews.llvm.org/D144963