[PATCH] D144986: [Dexter] Use non-blocking resume when debugging Visual Studio

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer created this revision.
StephenTozer added reviewers: jmorse, Orlando, CarlosAlbertoEnciso.
Herald added a project: All.
StephenTozer requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The Visual Studio debugger currently uses blocking calls to Go and StepInto, which interferes with Dexter's ability to do any processing (e.g. checking for time outs) in between. This patch updates these functions to use non-blocking calls.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D144986

Files:
  cross-project-tests/debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py


Index: cross-project-tests/debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py
===================================================================
--- cross-project-tests/debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py
+++ cross-project-tests/debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py
@@ -259,13 +259,13 @@
         ActiveConfiguration = self._fetch_property(project.Properties, 'ActiveConfiguration').Object
         ActiveConfiguration.DebugSettings.CommandArguments = cmdline_str
 
-        self._fn_go()
+        self._fn_go(False)
 
     def step(self):
-        self._fn_step()
+        self._fn_step(False)
 
     def go(self) -> ReturnCode:
-        self._fn_go()
+        self._fn_go(False)
         return ReturnCode.OK
 
     def set_current_stack_frame(self, idx: int = 0):


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D144986.501203.patch
Type: text/x-patch
Size: 839 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230228/6d8a33de/attachment-0001.bin>