[PATCH] D144907: [RegAllocFast] insert additional spills along indirect edges of INLINEASM_BR

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 28 10:07:22 PST 2023


nickdesaulniers added inline comments.


================
Comment at: llvm/lib/CodeGen/RegAllocFast.cpp:956
+        for (MachineBasicBlock *Succ : MI.getParent()->successors()) {
+          if (Succ->isInlineAsmBrIndirectTarget()) {
+            TII->storeRegToStackSlot(*Succ, Succ->begin(), PhysReg, Kill,
----------------
MatzeB wrote:
> Just wondering: Can there be multiple INLINEASM_BR within the same block where you would need a check to only deal with the successors of the current INLINEASM_BR?
You're right, INLINEASM_BR is not a terminator, so it's possible to have more than one within a single MachineBasicBlock. Let me rework this...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144907/new/

https://reviews.llvm.org/D144907



More information about the llvm-commits mailing list