[PATCH] D144956: Fix VGPR + offset Scratch offset folding

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 28 09:19:05 PST 2023


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp:1541
+          KnownBits AddrKnown = CurDAG->computeKnownBits(N0);
+          if (AddrKnown.isNonNegative()) {
+            Addr = N0;
----------------
How does this work? If this condition is false, then you never assign to Addr.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144956/new/

https://reviews.llvm.org/D144956



More information about the llvm-commits mailing list