[PATCH] D144162: [AMDGPU] Replace LegacyDA with Uniformity Analysis in AnnotateUniformValues

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/i1-copy-from-loop.ll:28
 ; SI-NEXT:    s_cmp_gt_u32 s14, 3
-; SI-NEXT:    s_cbranch_scc1 .LBB0_1
+; SI-NEXT:    s_cselect_b64 s[12:13], -1, 0
+; SI-NEXT:    s_and_b64 vcc, exec, s[12:13]
----------------
gandhi21299 wrote:
> foad wrote:
> > This is a regression.
> Should I handle all the regressions in a seperate patch?
Normally you would not commit a patch that causes regressions, unless you can explain them and get agreement that they are acceptable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144162/new/

https://reviews.llvm.org/D144162