[PATCH] D144963: [UTC] Include return type/attributes under --version 2

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 28 08:43:47 PST 2023


asb added a comment.

Firstly - thanks for picking this up again - I just came back to some work that would benefit, so was about to look myself. I'm grateful you've already done that rebasing!

This LGTM in general. I have just one question about how you imagine changing the incorporation of D140212 <https://reviews.llvm.org/D140212> - would you add in the `--function-signature` by default change to `--version 2`, or introduce a `--version 3`? I think I'd be happy enough with either, but wanted to check your plan.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144963/new/

https://reviews.llvm.org/D144963



More information about the llvm-commits mailing list