[PATCH] D144687: [GlobalISel][NFC] Add MachineInstr::getFirst[N]{Regs,LLTs}() helpers to extract regs & types.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 28 07:54:20 PST 2023


arsenm added a comment.

In D144687#4158484 <https://reviews.llvm.org/D144687#4158484>, @aemerson wrote:

> I’m also wondering for performance reasons whether we should have the types be returned via a single call. With the current patch we call getOperand() twice for each register and I’m not sure if they’ll get optimized to a single call. Maybe:
> auto [DstReg, DstTy, Src1Reg, Src1Ty] = MI.getFirst2RegsAndTys();

I’ve thought about adding a MachineValue that acts more like an SDValue which would track the type and index


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144687/new/

https://reviews.llvm.org/D144687



More information about the llvm-commits mailing list