[PATCH] D144211: [BOLT] computing raw branch count for yaml profiles

Sergey Pupyrev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 28 07:11:34 PST 2023


spupyrev added a comment.

In D144211#4157099 <https://reviews.llvm.org/D144211#4157099>, @Amir wrote:

> Is that primarily needed for "X out of Y samples in the binary (Z%) belong to functions with invalid (possibly stale) profile" log message? Can you add a test using yaml profile, e.g. based on bolt/test/X86/pre-aggregated-perf.test?

I noticed a few (minor) differences between how yaml and fdata profiles are parsed and processed -- this is one of them and can easily be fixed. I will add a test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144211/new/

https://reviews.llvm.org/D144211



More information about the llvm-commits mailing list