[PATCH] D144744: [IR][Legalization] Split illegal deinterleave and interleave vectors

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:2791-2795
+  Lo = ResLo.getValue(ResNo);
+  Hi = ResHi.getValue(ResNo);
+  unsigned OtherNo = 1 - ResNo;
+  SetSplitVector(SDValue(N, OtherNo), ResLo.getValue(OtherNo),
+                 ResHi.getValue(OtherNo));
----------------
I've no objection to you landing this patch as is but would it be simpler to handle all results within this function rather than setting `Lo` and `Hi`? Much like you have done for D144846.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144744/new/

https://reviews.llvm.org/D144744