[PATCH] D144701: [COFF][X86_64] Put jump table in .rdata for Windows

Tue Feb 28 05:46:11 PST 2023

wxiao3 added a comment.

In D144701#4157971 <https://reviews.llvm.org/D144701#4157971>, @mstorsjo wrote:

> Thanks for the updates!
>
> On second look, I'm a bit undecided and divided whether it's better to have the arch switch, or just keep it as it was (or include aarch64 in the switch too?). I guess it's fine with me either way. (And the aarch64 and arm cases should have their own testcases already, I believe.)
>
> For the testcase, can you include i386 or i686 too, since that's at least covered in the switch?

Restrict the change only to x86_64 for 2 reasons:

1. can't put jump table to text section for x86_32 since its jump table entry kind is EK_BlockAddress instead of EK_LabelDifference32
2. no idea about the performance impact to aarch64

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144701/new/

https://reviews.llvm.org/D144701