[PATCH] D144652: [Assignment Tracking] getIntrinsicInstrCost: set dbg.assign cost to zero

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added a comment.

> Does anyone have any good ideas on what a test for this looks like?

I can see a test that I think is meant to test this function, in `llvm/test/Analysis/CostModel` there are 3 tests which test the cost of intrinsics (`free-intrinsics-datalayout.ll`, `free-intrinsics-no_info.ll`, and `X86/free-intrinsics.ll`). Those tests are using the auto-generated check scripts though, and it looks like the debug intrinsics in those scripts are being dropped (`warning: ignoring debug info with an invalid version (0)`), so the update script doesn't produce a check-line for them. Given that this is effectively a trivial extension to untested code I don't think the lack of test should block this script; but it'd be a welcome if you fixed the debug info version issue in those tests, added a debug assign instance, and reran the update scripts to produce an actual test output (as long as it is trivial to do so).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144652/new/

https://reviews.llvm.org/D144652