[PATCH] D144711: [DAGCombiner] don't reuse the pointer info for merged store

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 28 03:19:38 PST 2023


shchenz added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:18995
+                         Objs);
+    if (Objs.size() != 1)
+      return false;
----------------
nikic wrote:
> This should use getUnderlyingObject() unless there's strong reason to be aggressive here.
Thanks. Looks good to me. No handling for multiple objects even use `getUnderlyingObjects()` to reduce the complexity.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144711/new/

https://reviews.llvm.org/D144711



More information about the llvm-commits mailing list