[PATCH] D144793: [DebugInfo] Upgrade `dbg.addr` to `dbg.value`

[J. Ryan Stinnett via Phabricator via llvm-commits]

jryans marked 2 inline comments as done.
jryans added inline comments.


================
Comment at: llvm/test/Bitcode/upgrade-dbg-addr.ll:18
+; CHECK: declare void @llvm.dbg.value(metadata, metadata, metadata)
+declare void @llvm.dbg.addr(metadata, metadata, metadata)
----------------
Orlando wrote:
> jryans wrote:
> > Orlando wrote:
> > > Did you exclude the metadata definitions on purpose and does the test work like this?
> > > 
> > > It seems odd to me, but I've not looked at the upgrade tests before.
> > The `.ll` content is not that meaningful here because only the `.bc` is actually used as an input (unlike most other tests). Bitcode tests seem to use this pattern regularly from what I could see.
> > 
> > In any case, yes, the test does pass like this. 🙂 
> Oh I see. Ok cool, that makes sense to me.
Now that I'm having to modify the test, I think it's better to have the full `.ll` file in tree for easier tweaking when needed. I'll keep the `.bc` as the test input though, since that seems to be the pattern here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144793/new/

https://reviews.llvm.org/D144793