[PATCH] D144699: [llvm][Uniformity] provide overloads for Instruction* and Value*

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 28 02:27:50 PST 2023


foad added a comment.

I'm fine with the patch but I don't particularly like the fact that DA has an `isDivergent(Instruction *)` in the first place, because it's really unclear what it means - for non-void instructions I guess it's the same as `isDivergent(Value *)`, and for conditional branches it means something specific, and for other instructions...? I'd much prefer for have a more specific `isDivergentBranch(BranchInst *)`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144699/new/

https://reviews.llvm.org/D144699



More information about the llvm-commits mailing list