[PATCH] D144939: [SimplifyCFG] Handle MD_noundef when hoisting common codes

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 28 00:46:37 PST 2023


nikic added a comment.

Looks like the new test fails?



================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:1621-1633
         unsigned KnownIDs[] = {LLVMContext::MD_tbaa,
-                               LLVMContext::MD_range,
                                LLVMContext::MD_fpmath,
                                LLVMContext::MD_invariant_load,
                                LLVMContext::MD_nonnull,
                                LLVMContext::MD_invariant_group,
                                LLVMContext::MD_align,
                                LLVMContext::MD_dereferenceable,
----------------
StephenFan wrote:
> Whether these can be replaced with combineMetadataCSE?
Yes, let's replace this with combineMetadataForCSE


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144939/new/

https://reviews.llvm.org/D144939



More information about the llvm-commits mailing list