[PATCH] D144765: [llvm-lib] Add basic support for generating a Windows import library from a .def file.

[Vadim Paretsky via Phabricator via llvm-commits]

vadikp-intel marked 4 inline comments as done.
vadikp-intel added inline comments.


================
Comment at: llvm/lib/ToolDrivers/llvm-lib/Options.td:25
 def out    : P<"out", "Path to file to write output">;
+def DEF    : P<"DEF", "DEF file to use to generate import library">;
 
----------------
mstorsjo wrote:
> I'd prefer if we'd stick to consistent casing with the existing ones here, i.e. lowercasing both occurrances of `DEF` here. Or is there an issue that the first one can't be called `def` since that's a tablegen keyword? In that case, leave a comment saying that, like for `list` just a few lines above. Or maybe rather make it e.g. `deffile` instead of `DEF` (with a comment explaining the reason). `deffile` seems to be what it's called in lld anyway.
'def' is a reserved word, so have to use 'DEF' here (the end result is more or less the same). I've changed it to be lowercase in the help string. 'deffile' would not be lib compatible and also complicate things in CMAKE which unconditionally defines CMAKE_LINK_DEF_FILE_FLAG to '/DEF:', I believe.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144765/new/

https://reviews.llvm.org/D144765