[PATCH] D144770: [SLP] Outline GEP chain cost modeling into new TTI interface - NFCI.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added a comment.

In D144770#4157230 <https://reviews.llvm.org/D144770#4157230>, @vdmitrie wrote:

> In D144770#4157226 <https://reviews.llvm.org/D144770#4157226>, @ABataev wrote:
>
>> In D144770#4157187 <https://reviews.llvm.org/D144770#4157187>, @vdmitrie wrote:
>>
>>> In D144770#4153415 <https://reviews.llvm.org/D144770#4153415>, @RKSimon wrote:
>>>
>>>> I'd expect this to cause cost changes - have you had any luck creating tests demonstrating that?
>>>
>>> I was not able to make one. Existing tests that are sensitive to this cost modeling are:
>>>
>>> - for plain wide loads:
>>>
>>> llvm/test/Transforms/SLPVectorizer/X86/remark_horcost.ll
>>> llvm/test/Transforms/SLPVectorizer/X86/remark_not_all_parts.ll
>>>
>>> - for gather loads:
>>>
>>> llvm/test/Transforms/SLPVectorizer/X86/remark_gather-load-redux-cost.ll
>>>
>>> But yep, I agree that this is not a great coverage.
>>
>> Make them to emit remarks with costs estimations?
>
> I'm not sure I understand.  All these tests do already check for pass-remarks output which includes vec tree cost. Did you mean something else?

I thought they don't have remarks. Maybe add remarks to some other tests?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144770/new/

https://reviews.llvm.org/D144770