[PATCH] D144830: [asan darwin] Allow clients to implement `__sanitizer_report_error_summary`

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 27 16:56:18 PST 2023


vitalybuka added a comment.

In D144830#4157098 <https://reviews.llvm.org/D144830#4157098>, @vitalybuka wrote:

> In D144830#4157090 <https://reviews.llvm.org/D144830#4157090>, @dmaclach wrote:
>
>> Switched over to using "__sanitizer_sandbox_on_notify" from "__sanitizer_print_stack_trace" because it's available in the internal headers and serves the same purpose.
>
> This is also weak symbol which is expected to be redefined by user, like original __sanitizer_report_error_summary

actually it's defined by sanitizer, not sure why this is weak

What is wrong with __sanitizer_print_stack_trace? Seems like more stable bet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144830/new/

https://reviews.llvm.org/D144830



More information about the llvm-commits mailing list