[PATCH] D144830: [asan darwin] Allow clients to implement `__sanitizer_report_error_summary`

Mon Feb 27 15:00:24 PST 2023

yln added a comment.

Thank you @dmaclach!

The explanation of the problem und fix make sense to me.  Can we add a test for this in sanitizer_common?

Note, I refactored this code in D129157 <https://reviews.llvm.org/D129157>, but the choice of `__sanitizer_report_error_summary` predates that: D129157#4156731 <https://reviews.llvm.org/D129157#4156731>

LGTM, but let's add a test for this in sanitizer_common.

================
Comment at: b/llvm/llvm-project/compiler-rt/lib/sanitizer_common/sanitizer_mac.cpp:991
+  // "__sanitizer_print_stack_trace" is an exported function that we do
+  // not support clients implementing.
   Dl_info info_puts, info_runtime;
----------------
"__sanitizer_print_stack_trace" is an exported function, but not overridable by the client.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144830/new/

https://reviews.llvm.org/D144830