[llvm] 4364e24 - [NFC][PGO] Prefix duplicate profile MemOp entry diagnostic with 'warning:'
Matthew Voss via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 27 14:08:36 PST 2023
Author: Matthew Voss
Date: 2023-02-27T14:04:27-08:00
New Revision: 4364e2429cd4e3a640cbb84e565420fcfa830478
URL: https://github.com/llvm/llvm-project/commit/4364e2429cd4e3a640cbb84e565420fcfa830478
DIFF: https://github.com/llvm/llvm-project/commit/4364e2429cd4e3a640cbb84e565420fcfa830478.diff
LOG: [NFC][PGO] Prefix duplicate profile MemOp entry diagnostic with 'warning:'
Adding this prefix will indicate clearly that the compiler doesn't exit
when it hits this diagnostic. Searches for other non-fatal diagnostics
will also be able to find this diagnostic easily.
Added:
Modified:
llvm/lib/Transforms/Instrumentation/PGOMemOPSizeOpt.cpp
llvm/test/Transforms/PGOProfile/consecutive-zeros.ll
Removed:
################################################################################
diff --git a/llvm/lib/Transforms/Instrumentation/PGOMemOPSizeOpt.cpp b/llvm/lib/Transforms/Instrumentation/PGOMemOPSizeOpt.cpp
index 35db8483fc913..2906fe1909840 100644
--- a/llvm/lib/Transforms/Instrumentation/PGOMemOPSizeOpt.cpp
+++ b/llvm/lib/Transforms/Instrumentation/PGOMemOPSizeOpt.cpp
@@ -317,7 +317,7 @@ bool MemOPSizeOpt::perform(MemOp MO) {
}
if (!SeenSizeId.insert(V).second) {
- errs() << "Invalid Profile Data in Function " << Func.getName()
+ errs() << "warning: Invalid Profile Data in Function " << Func.getName()
<< ": Two identical values in MemOp value counts.\n";
return false;
}
diff --git a/llvm/test/Transforms/PGOProfile/consecutive-zeros.ll b/llvm/test/Transforms/PGOProfile/consecutive-zeros.ll
index 6634838d21e1a..a7337d04531a1 100644
--- a/llvm/test/Transforms/PGOProfile/consecutive-zeros.ll
+++ b/llvm/test/Transforms/PGOProfile/consecutive-zeros.ll
@@ -5,7 +5,7 @@ target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16
target triple = "x86_64-unknown-linux-gnu"
define void @foo(ptr %dst, ptr %src, ptr %a, i32 %n) {
-; CHECK: Invalid Profile
+; CHECK: warning: Invalid Profile
entry:
br label %for.cond
More information about the llvm-commits
mailing list