[PATCH] D142615: [WebAssembly] Fix tail call with return_call_indirect instruction

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 27 13:45:54 PST 2023


aheejin accepted this revision.
aheejin added a comment.
This revision is now accepted and ready to land.

LGTM % comment



================
Comment at: llvm/test/CodeGen/WebAssembly/tailcall.ll:260
 
+; Note: the second global.set is to restore the SP.
+; CHECK-LABEL: alloca_and_indirect_tail_call
----------------
Can you add a little more comment that says this test is to test if SP restoring code is generated correctly before the `return_call`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142615/new/

https://reviews.llvm.org/D142615



More information about the llvm-commits mailing list