[PATCH] D142803: [LogicCombine 1/?] Implement a general way to simplify logical operations.

Mon Feb 27 11:19:16 PST 2023

xbolva00 added a comment.

In D142803#4156053 <https://reviews.llvm.org/D142803#4156053>, @aeubanks wrote:

> In D142803#4156050 <https://reviews.llvm.org/D142803#4156050>, @xbolva00 wrote:
>
>> In D142803#4156027 <https://reviews.llvm.org/D142803#4156027>, @aeubanks wrote:
>>
>>> with this patch, would it possible to remove some similar optimizations from instcombine, those being subsumed by this?
>>
>> AggressiveInstCombine runs only with -O3, no?
>>
>> Removing instcombine folds would regress performance with lower levels. This leads me to the question how ofter this fires in llvm test suite / SPEC / clang bootstrap? Is it worth it?
>
> Ah yes you're right. Might be worth considering running it under -O2 as well?

Yeah! I believe that last time even the impact on compile times was quite low.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142803/new/

https://reviews.llvm.org/D142803