[PATCH] D144891: [SCEV] Add SCEVType to represent `vscale`.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 27 10:49:23 PST 2023


efriedma added reviewers: reames, mkazantsev.
efriedma added a comment.

Seems reasonable to me.



================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:730
+    // VScale represents the same single value.
+    return 0;
+  }
----------------
The "return 0" shouldn't be reachable; if two vscales have the same type, "LHS == RHS" should be true.

You can probably just skip checking "if (LTy != RTy)".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144891/new/

https://reviews.llvm.org/D144891



More information about the llvm-commits mailing list