[PATCH] D144747: [lld][WebAssembly] Fix handling of mixed strong and weak references

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 27 10:03:27 PST 2023


dschuff accepted this revision.
dschuff added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/test/wasm/weak-undefined.s:39
+
+# RUN: llvm-mc -filetype=obj -triple=wasm32-unknown-unknown %p/Inputs/strong-refs.s -o %t-strong.o
+# RUN: not wasm-ld -strip-all %t.o %t-strong.o -o %t.wasm 2>&1 | FileCheck --check-prefix=ERROR %s
----------------
Should these RUN lines all be at the top? that seems to be the convention in most test files AFAIK?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144747/new/

https://reviews.llvm.org/D144747



More information about the llvm-commits mailing list