[PATCH] D144777: [InstCombine] Fold signbit test of a pow2 or zero

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

LGTM - thanks!
See inline comments for a small adjustment to the tests.



================
Comment at: llvm/test/Transforms/InstCombine/fold-signbit-test-power2.ll:25
+  call void @use_i1(i1 %cmp.2)
+  %cmp.3 = icmp ult i8 %pow2_or_zero, -128
+  call void @use_i1(i1 %cmp.3)
----------------
I'd rather not add this "is_not_negative / ult" instruction to this test. It is confusing given the test name.


================
Comment at: llvm/test/Transforms/InstCombine/fold-signbit-test-power2.ll:56
+  call void @use_i1_vec(<2 x i1> %cmp.2)
+  %cmp.3 = icmp ult <2 x i8> %pow2_or_zero, <i8 -128, i8 -128>
+  call void @use_i1_vec(<2 x i1> %cmp.2)
----------------
I'd rather not add this "is_not_negative / ult" instruction to this test. It is confusing given the test name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144777/new/

https://reviews.llvm.org/D144777